Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html fotter ux design #964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update index.html fotter ux design #964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,6 +898,16 @@
height: 100%;
background-color: #3f10ea;
}
.footer-content{
background-color: black;
transition:all;
transition-property: font-size;
transition-duration: 4s;
transition-delay: 2s;
}
.footer-content:hover{
transform: scale(1.1)
}
Comment on lines +901 to +910
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Adjust footer animation parameters for better user experience.

The current footer animation settings might be disruptive:

  • 4-second transition duration is too long
  • 2-second delay before animation starts
  • Scale transform of 1.1 might cause content overflow

Consider these adjustments:

 .footer-content {
   background-color: black;
-  transition: all;
-  transition-property: font-size;
-  transition-duration: 4s;
-  transition-delay: 2s;
+  transition: transform 0.3s ease;
 }
 .footer-content:hover {
-  transform: scale(1.1)
+  transform: scale(1.02)
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.footer-content{
background-color: black;
transition:all;
transition-property: font-size;
transition-duration: 4s;
transition-delay: 2s;
}
.footer-content:hover{
transform: scale(1.1)
}
.footer-content{
background-color: black;
transition: transform 0.3s ease;
}
.footer-content:hover{
transform: scale(1.02)
}

</style>
</head>

Expand Down Expand Up @@ -1128,4 +1138,4 @@ <h3>Connect With Us</h3>

</body>

</html>
</html>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Address accessibility and performance concerns.

Several accessibility and performance issues need attention:

  1. Missing alt text for chatbot GIF
  2. Progress bar implementation causes frequent DOM updates
  3. Social media links lack proper aria-labels

Apply these improvements:

- <img class="h-20" src="chatbot.gif" alt="chatbot">
+ <img class="h-20" src="chatbot.gif" alt="Chat assistance bot icon - Click to open chat">

- <a href="https://www.facebook.com/"><i class="fab fa-facebook-f"></i></a>
+ <a href="https://www.facebook.com/" aria-label="Visit our Facebook page"><i class="fab fa-facebook-f"></i></a>

For the progress bar, consider using requestAnimationFrame:

function updateProgressBar() {
  requestAnimationFrame(() => {
    const scrollTop = window.scrollY;
    const windowHeight = document.documentElement.scrollHeight - window.innerHeight;
    const scrollPercentage = (scrollTop / windowHeight) * 100;
    
    lastScrollPercentage += (scrollPercentage - lastScrollPercentage) * 0.1;
    progressBar.style.width = lastScrollPercentage + '%';
  });
}