change the font #852
change the font #852
Conversation
WalkthroughThe changes in this pull request focus on the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
about.html (4)
Line range hint
153-158: Remove duplicate CSS variable definitions.The
:rootCSS variables are defined twice in the file. The second definition at line 153 is redundant as these variables are already defined at line 18.Remove the duplicate definition:
-:root { - --deep-teal: #003d4d; - --off-white: #f8f9fa; - --dark-slate: #2f4f4f; - --soft-gold: #d9c79e; -}
Line range hint
419-432: Fix invalid navbar structure.There are several issues in the navbar section:
- Nested
navelements with duplicatenavbarclass- Unclosed
navtag- Misplaced
divclosing tagApply this fix to correct the structure:
- <h1 style="font-family: Arial, sans-serif;">Resum Resume</h1> - <nav class="navbar"> - <div class="tabs-container"></div> + <h1 style="font-family: Arial, sans-serif;">Resum Resume</h1> + <div class="tabs-container"> <a class="tab" href="index.html">Home</a> <a class="tab" href="about.html">About</a> <a class="tab" href="resume.html">Build Resume</a> <a class="tab" href="resume_tips.html">Resume Tips</a> <a class="tab" href="signup.html">Sign Up</a> <a class="tab" href="login.html">Login</a> <a class="tab" href="privacypolicy.html">Privacy Policy</a> - </div> - </nav> + </div>
Line range hint
484-486: Improve image accessibility with meaningful alt text.The current alt text for card images appears to be missing or uses auto-generated filenames. This doesn't provide meaningful information for screen readers and fails accessibility requirements.
Update the alt text to describe the image content:
- <img src="images/Gemini_Generated_Image_fx9dejfx9dejfx9d.jpg" alt=""> + <img src="images/Gemini_Generated_Image_fx9dejfx9dejfx9d.jpg" alt="Illustration representing our mission and goals"> - <img src="images/Gemini_Generated_Image_52rg8r52rg8r52rg.jpg" alt=""> + <img src="images/Gemini_Generated_Image_52rg8r52rg8r52rg.jpg" alt="Step-by-step guide illustration"> - <img src="images/Gemini_Generated_Image_ootrdvootrdvootr.jpg" alt=""> + <img src="images/Gemini_Generated_Image_ootrdvootrdvootr.jpg" alt="Benefits and features illustration">Also applies to: 495-497, 508-510
Line range hint
447-463: Optimize progress bar performance.The current progress bar implementation may cause performance issues due to:
- Frequent style updates during scroll
- Potential layout thrashing from reading scrollY and updating width in the same function
Consider these optimizations:
function updateProgressBar() { - const scrollTop = window.scrollY; - const windowHeight = document.documentElement.scrollHeight - window.innerHeight; - const scrollPercentage = (scrollTop / windowHeight) * 100; - - const progressBar = document.getElementById('progress-bar'); - - - lastScrollPercentage += (scrollPercentage - lastScrollPercentage) * 0.1; - progressBar.style.width = lastScrollPercentage + '%'; + // Use requestAnimationFrame for smooth animation + requestAnimationFrame(() => { + const scrollTop = window.scrollY; + const windowHeight = document.documentElement.scrollHeight - window.innerHeight; + const scrollPercentage = (scrollTop / windowHeight) * 100; + + const progressBar = document.getElementById('progress-bar'); + + // Use transform instead of width for better performance + lastScrollPercentage += (scrollPercentage - lastScrollPercentage) * 0.1; + progressBar.style.transform = `translateX(${lastScrollPercentage}%)`; + }); } -window.addEventListener('scroll', updateProgressBar); +// Throttle scroll events for better performance +let ticking = false; +window.addEventListener('scroll', () => { + if (!ticking) { + ticking = true; + updateProgressBar(); + setTimeout(() => ticking = false, 16); // ~60fps + } +});
Pull Request for Resum-Resume 💡#390
Issue Title :
Closes: #issue number that will be closed through this PR
Describe the add-ons or changes you've made 📃
Give a clear description of what have you added or modifications made
Type of change ☑️
What sort of change have you made:
How Has This Been Tested? ⚙️
Describe how it has been tested
Describe how have you verified the changes made
Checklist: ☑️
Summary by CodeRabbit
New Features
Bug Fixes
Style