fix: return AddressNotFound instead of EntityError

src/address/error.rs

@@ -6,6 +6,8 @@ pub enum AddressError {
     ExternalIdAlreadyExists,
     #[error("AddressError - external_id does not exist")]
     ExternalIdNotFound,
+    #[error("AddressError - Could not find address: {0}")]
+    AddressNotFound(String),
     #[error("AddressError - Sqlx: {0}")]
     Sqlx(sqlx::Error),
     #[error("AddressError - EntityError: {0}")]

src/address/repo.rs

@@ -161,6 +161,11 @@ impl Addresses {
         )
         .fetch_all(&self.pool)
         .await?;
+
+        if rows.is_empty() {
+            return Err(AddressError::AddressNotFound(address));
+        }
+
         let mut events = EntityEvents::new();
         for row in rows {
             events.load_event(row.sequence as usize, row.event)?;

src/api/server/convert.rs

@@ -553,6 +553,9 @@ impl From<ApplicationError> for tonic::Status {
             ApplicationError::AddressError(AddressError::ExternalIdNotFound) => {
                 tonic::Status::not_found(err.to_string())
             }
+            ApplicationError::AddressError(AddressError::AddressNotFound(_)) => {
+                tonic::Status::not_found(err.to_string())
+            }
             ApplicationError::AddressError(AddressError::ExternalIdAlreadyExists) => {
                 tonic::Status::already_exists(err.to_string())
             }