fix: handle negative balances and trigger an alert

GaloyMoney · Jan 14, 2025 · 655b44a · 655b44a
1 parent 16725c5
commit 655b44a
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 10 deletions.
diff --git a/src/api/server/convert.rs b/src/api/server/convert.rs
@@ -362,17 +362,52 @@ impl From<(WalletSummary, Vec<Payout>)> for proto::BatchWalletSummary {
 
 impl From<WalletBalanceSummary> for proto::GetWalletBalanceSummaryResponse {
     fn from(balance: WalletBalanceSummary) -> Self {
+        let has_negative_balance = [
+            balance.utxo_settled.is_negative(),
+            balance.utxo_pending_incoming.is_negative(),
+            balance.utxo_pending_outgoing.is_negative(),
+            balance.utxo_encumbered_incoming.is_negative(),
+            balance.fees_pending.is_negative(),
+            balance.fees_encumbered.is_negative(),
+            balance.effective_settled.is_negative(),
+            balance.effective_pending_income.is_negative(),
+            balance.effective_pending_outgoing.is_negative(),
+            balance.effective_encumbered_outgoing.is_negative(),
+        ]
+        .iter()
+        .any(|&x| x);
+
+        if has_negative_balance {
+            tracing::Span::current().record("error", true);
+            tracing::Span::current().record(
+                "error.message",
+                "Negative balance values detected in wallet summary",
+            );
+            tracing::Span::current().record(
+                "error.level",
+                tracing::field::display(tracing::Level::ERROR),
+            );
+        }
+
         Self {
-            utxo_encumbered_incoming: u64::from(balance.utxo_encumbered_incoming),
-            utxo_pending_incoming: u64::from(balance.utxo_pending_incoming),
-            utxo_settled: u64::from(balance.utxo_settled),
-            utxo_pending_outgoing: u64::from(balance.utxo_pending_outgoing),
-            fees_pending: u64::from(balance.fees_pending),
-            fees_encumbered: u64::from(balance.fees_encumbered),
-            effective_pending_income: u64::from(balance.effective_pending_income),
-            effective_settled: u64::from(balance.effective_settled),
-            effective_pending_outgoing: u64::from(balance.effective_pending_outgoing),
-            effective_encumbered_outgoing: u64::from(balance.effective_encumbered_outgoing),
+            utxo_encumbered_incoming: u64::from(
+                balance.utxo_encumbered_incoming.max(Satoshis::ZERO),
+            ),
+            utxo_pending_incoming: u64::from(balance.utxo_pending_incoming.max(Satoshis::ZERO)),
+            utxo_settled: u64::from(balance.utxo_settled.max(Satoshis::ZERO)),
+            utxo_pending_outgoing: u64::from(balance.utxo_pending_outgoing.max(Satoshis::ZERO)),
+            fees_pending: u64::from(balance.fees_pending.max(Satoshis::ZERO)),
+            fees_encumbered: u64::from(balance.fees_encumbered.max(Satoshis::ZERO)),
+            effective_pending_income: u64::from(
+                balance.effective_pending_income.max(Satoshis::ZERO),
+            ),
+            effective_settled: u64::from(balance.effective_settled.max(Satoshis::ZERO)),
+            effective_pending_outgoing: u64::from(
+                balance.effective_pending_outgoing.max(Satoshis::ZERO),
+            ),
+            effective_encumbered_outgoing: u64::from(
+                balance.effective_encumbered_outgoing.max(Satoshis::ZERO),
+            ),
         }
     }
 }

diff --git a/src/primitives/mod.rs b/src/primitives/mod.rs
@@ -270,6 +270,10 @@ impl Satoshis {
     pub fn abs(&self) -> Self {
         Self(self.0.abs())
     }
+
+    pub fn is_negative(&self) -> bool {
+        self.0.is_sign_negative()
+    }
 }
 
 impl From<Decimal> for Satoshis {