Dm/control align #365
Merged
Dm/control align #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are to be used to compare instruction traces of original vs. patched CFARs. Also refactor 'zipSeq' to use caching
… flow This adds an additional set of actions for adding an assumption/assertion/equivalence condition stating that both the original and patched CFARs execute the exact same instructions in the same order. This is intended to handle the common case where the analysis has proceeded past the location of the patch and is now discovering control flow divergences that are a result of the equivalence domain being weakened from exact equality. These divergences are either spurious and can be resolved by asserting control flow alignment, or are actual differences introduced by the patch and can be resolved by adding control flow alignment as an equivalence condition at this point.
Note that this just prevents warnings from being shown in the TraceTree or emitted in the log. Warnings that affect verification (e.g. non-total block exits) will still affect the final result.
…cates This makes the resulting predicates from control flow alignment slightly more readable after simplification
Does not yet add target 3 to the test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.