Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dm/eqcond traces #364

Merged
merged 8 commits into from
Mar 1, 2024
Merged

Dm/eqcond traces #364

merged 8 commits into from
Mar 1, 2024

Conversation

danmatichuk
Copy link
Collaborator

No description provided.

This is for the benefit of the JSON output, so that all of the final
output appears in a single object, rather than requiring navigating
through the TraceTree
…ivalence conditions

Each simplifier instance caches its intermediate results, and so the
implicit (and unchecked) assumption is that the assumption context
is the same between each execution of the simplifier.

Since each node has a different assumption context, formally we
shouldn't reuse the same simplifier to avoid using invalid cached results.
@danmatichuk danmatichuk marked this pull request as ready for review March 1, 2024 08:53
@danmatichuk danmatichuk merged commit c10939d into master Mar 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant