Add plausible heuristics for PPC32 PLT stubs #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, PATE had no PLT stub-finding heuristics for PPC32, which meant that PATE would crash whenever it tried to execute code that invokes a PLT stub. While it is difficult in general to predict what the layout of a `.plt` section will be on an arbitrary PPC32 binary, we can at least give PATE some plausible heuristics that were derived from the `target1-self` binary. Previously, the code in `Pate.Discovery.PLT` hard-coded heuristics that were specific to AArch32, so this patch needed to cargo-cult some code from GaloisInc/macaw#320 in order to appropriately generalize the code to other architectures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, PATE had no PLT stub-finding heuristics for PPC32, which meant that PATE would crash whenever it tried to execute code that invokes a PLT stub. While it is difficult in general to predict what the layout of a
.pltsection will be on an arbitrary PPC32 binary, we can at least give PATE some plausible heuristics that were derived from thetarget1-selfbinary.Previously, the code in
Pate.Discovery.PLThard-coded heuristics that were specific to AArch32, so this patch needed to cargo-cult some code from GaloisInc/macaw#320 in order to appropriately generalize the code to other architectures.