Generalize lazy memory model using HasMacawLazySimulatorState
#358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a `HasMacawLazySimulatorState` data type, which provides a "classy lens" for accessing a `MacawLazySimulatorState` within some Crucible personality type. It also generalizes the lazy `macaw-symbolic` memory model in `Data.Macaw.Symbolic.Memory.Lazy` to be polymorphic over `HasMacawLazySimulatorState` instances. The upside is that it is now possible to use the lazy memory model at other personality types besides just `MacawLazySimulatorState`, making it much easier to extend the memory model. Because there is a `HasMacawLazySimulatorState` instance for `MacawLazySimulatorState`, existing code that uses `MacawLazySimulatorState` should continue to compile without changes. Fixes #357.
langston-barrett
approved these changes
Dec 11, 2023
danmatichuk
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
HasMacawLazySimulatorStatedata type, which provides a "classy lens" for accessing aMacawLazySimulatorStatewithin some Crucible personality type. It also generalizes the lazymacaw-symbolicmemory model inData.Macaw.Symbolic.Memory.Lazyto be polymorphic overHasMacawLazySimulatorStateinstances. The upside is that it is now possible to use the lazy memory model at other personality types besides justMacawLazySimulatorState, making it much easier to extend the memory model.Because there is a
HasMacawLazySimulatorStateinstance forMacawLazySimulatorState, existing code that usesMacawLazySimulatorStateshould continue to compile without changes.Fixes #357.