Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused extension #353

Merged
merged 1 commit into from
Dec 7, 2023
Merged

remove unused extension #353

merged 1 commit into from
Dec 7, 2023

Conversation

Ptival
Copy link
Contributor

@Ptival Ptival commented Dec 7, 2023

No description provided.

@Ptival Ptival requested a review from RyanGlScott December 7, 2023 17:10
RyanGlScott
RyanGlScott approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, although I'm not confident that we can avoid re-introducing redundant language extensions without some kind of automated check in the CI.

@Ptival Ptival merged commit 9e09fc8 into master Dec 7, 2023
3 checks passed
@Ptival Ptival deleted the vr/remove-extension branch December 7, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ptival @RyanGlScott