Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoders: support avoid == bytes in error message #1877

Merged
merged 3 commits into from
May 7, 2021
Merged

encoders: support avoid == bytes in error message #1877

merged 3 commits into from
May 7, 2021

Conversation

huntergregal
Copy link
Contributor

Mention'd in #1875. Python3 specific

Fixes an issue where encoder error message raises an exception when avoid is bytes like so:

encode(sc, avoid='\x01') vs encode(sc, avoid=b'\x01')

@Arusekk
Copy link
Member

Arusekk commented May 7, 2021

FYI: no need to update the changelog for one-line fixes, this avoids unnecessary conflicts in it

Arusekk
Arusekk reviewed May 7, 2021
View reviewed changes
pwnlib/encoders/encoder.py Outdated Show resolved Hide resolved
@Arusekk Arusekk merged commit 21d1cd0 into Gallopsled:dev May 7, 2021
@huntergregal huntergregal deleted the encoder_bytes_error branch September 23, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arusekk Arusekk Arusekk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huntergregal @Arusekk