Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDLayerWriter fixes #6199

Merged

Conversation

johnhaddon
Copy link
Member

This fixes #6197, and also cleans up the contexts in which USDLayerWriter evaluates the input scenes.

@johnhaddon johnhaddon requested a review from ericmehl January 8, 2025 14:22
@johnhaddon johnhaddon self-assigned this Jan 8, 2025
@johnhaddon johnhaddon marked this pull request as ready for review January 8, 2025 14:22
@ericmehl ericmehl merged commit 8e26e30 into GafferHQ:1.4_maintenance Jan 8, 2025
5 checks passed
@ericmehl
Copy link
Collaborator

ericmehl commented Jan 8, 2025

I found a way to set a directory to be read-only on Windows - it's not pretty but at least it's a one-liner. chmod doesn't do the job for directories, and Windows' convoluted permissions scheme needs a little more prodding to get it to prevent writing into a directory.

If that seems like a good solution, it's probably worth doing the same for

@unittest.skipIf( os.name == "nt", "Windows allows new files in read-only directories" )
def testNonWritableDirectory( self ) :

@johnhaddon johnhaddon deleted the usdLayerWriterPermissionsFix branch January 21, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Pending release
Development

Successfully merging this pull request may close these issues.

2 participants