Shader : Handle ContextProcessors within the shader network #6198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has a big caveat at present : it creates a unique shader in the network for every node/context pair visited. But we should be able to reuse sub-networks when they are seen in different contexts but result in the same thing anyway.
johnhaddon
force-pushed
the
contextProcessorsInShaders
branch
from
6f5d616 to
a3d5a4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR so we can get a build deployed for initial testing and internal development at Cinesite. This initial implementation works, but duplicates shaders unnecessarily if they are seen in different contexts but don't actually vary in those contexts. We won't merge until we have that sorted. Don't review just yet - let me get my ducks in a row first.