VisualiserTool : Drag value from buttonPress()
#6192
Merged
+19
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were returning the cursor value at
dragBegin()
, which would be slightly different from what the user would expect from pressing and holding the cursor and noting the value shown on hover.This is due to updating the cursor value during the small movement required to signal a drag. Holding the cursor value at the time of
buttonPress()
, allows us to use that as the drag value.Fixes #6191.
Checklist