Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisualiserTool : Drag value from buttonPress() #6192

Merged

Conversation

ericmehl
Copy link
Collaborator

@ericmehl ericmehl commented Jan 6, 2025

Previously, we were returning the cursor value at dragBegin(), which would be slightly different from what the user would expect from pressing and holding the cursor and noting the value shown on hover.

This is due to updating the cursor value during the small movement required to signal a drag. Holding the cursor value at the time of buttonPress(), allows us to use that as the drag value.

Fixes #6191.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

Sorry, something went wrong.

Previously, we were returning the cursor value at `dragBegin()`, which
would be slightly different from what the user would expect from
pressing and holding the cursor and noting the value shown on hover.

This is due to updating the cursor value during the small movement
required to signal a drag. Holding the cursor value at the time of
`buttonPress()`, allows us to use that as the drag value.

Fixes GafferHQ#6191.
@johnhaddon johnhaddon merged commit edab541 into GafferHQ:1.5_maintenance Jan 7, 2025
5 checks passed
@johnhaddon
Copy link
Member

Nice one - thanks Eric!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants