-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render Pass Menu #6177
Open
murraystevenson
wants to merge
10
commits into
GafferHQ:1.5_maintenance
Choose a base branch
from
murraystevenson:renderPassMenu
base: 1.5_maintenance
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Render Pass Menu #6177
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e4e5b4e
PlugLayout : Use placeholder for errored or invalid customWidgets
murraystevenson b9e8e63
PlugLayout : Support width metadata on customWidgets
murraystevenson 27a348b
ScriptWindow : Improve lifetime handling of acquired ScriptWindows
murraystevenson 83ff385
ScriptNodeAlgo : Add methods to edit and acquire `renderPass` plug
murraystevenson 89a4281
RenderPassEditor : Crop icons to 14 pixels
murraystevenson 34f5783
RenderPassEditor : Add RenderPassChooserWidget
murraystevenson d65b37a
_StyleSheet : Darken MenuButtons added to main MenuBar
murraystevenson a39941a
RenderPassEditor : Display adaptor disabled render passes
murraystevenson b40973a
RenderPassEditor : Display adaptor deleted render passes as disabled
murraystevenson 9293fc3
fixup! RenderPassEditor : Add RenderPassChooserWidget
murraystevenson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is a bit too API-ey to use as a category here. Maybe just "Menu Bar"? We could always add an API entry to mention the RenderPassChooserWidget.
Quite a lot of froms! Maybe just "choose the current render pass from those provided by the focus node"?