Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationTest : Increase pause before checking process name (2nd attempt) #6165

Open
wants to merge 1 commit into
base: 1.5_maintenance
Choose a base branch
from

Conversation

ivanimanishi
Copy link
Member

This ensures the process has had time to change its own name.

This is part of the effort to get the gaffer tests to pass inside IE's environment.
1s wasn't enough of a pause to guarantee that the gaffer process had had time to startup, import the Gaffer module, and then rename the process, before the test would check for the name. That's likely related to the use of non-local storage and loading extra startups.

2s does seem to be enough, but I added an extra second for safety.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

This ensures the process has had time to change its own name.
@ivanimanishi
Copy link
Member Author

@johnhaddon , other than resolving the conflict with the Changes file, I think this PR should be ok.
I initially targeted main, and I think that messed up the Version Check somehow.
But let me know if you think I need to address that, and how.

@ivanimanishi
Copy link
Member Author

@johnhaddon , anything I need to do on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant