GafferUITest : Fix assertNodeUIsHaveExpectedLifetime() test
#6127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Oct 31, 2024
python/GafferUITest/TestCase.py
Outdated
| @@ -169,6 +169,9 @@ def assertNodeUIsHaveExpectedLifetime( self, module ) : | |||
| weakScript = weakref.ref( script ) | |||
|
|
|||
| nodeGadget = GafferUI.NodeGadget.create( script["node"] ) | |||
| if not nodeGadget : | |||
| continue | |||
There was a problem hiding this comment.
This means we're skipping the tests for weakNodeUI just because a NodeGadget isn't registered. Could you move the assertIsNone for that above here so it still runs?
There was a problem hiding this comment.
Updated it in place so that only the nodeGadget related tests are skipped if it's None.
Hopefully that's what you meant?
There was a problem hiding this comment.
Yep, that's great - thanks Ivan!
ivanimanishi
force-pushed
the
gafferTestFix
branch
from
ad59391 to
247ac81
Compare
This test was raising an exception for nodes that are supposed to be "invisible", and therefore had no `NodeGadget`.
johnhaddon
force-pushed
the
gafferTestFix
branch
from
247ac81 to
5843546
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was raising an exception for nodes that are supposed to be "invisible", and therefore had no
NodeGadget.Related issues
assertNodeUIsHaveExpectedLifetime()test on modules that include invisible nodes.Dependencies
None
Breaking changes
None
Checklist