ColorPlugValueWidget : Lazy ColorShooser
create
#6063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the performance of creating a
ColorPlugValueWidget
by deferring the creation of the internal color chooser to when it is first made visible.For a single
ColorPlugValueWidget
, the difference is not all that noticeable, but for a node such asaiStandardSurface
, the improved creation time of all the widgets in the node editor is subtly faster.It's also noticeably faster when testing on top of #6003 where we are adding a number of additional widgets and increasing the amount of time needed to populate the node editor when not deferring color chooser creation.
For me, some timings when selecting an
aiStandardSurface
node :ColorChooser
without deferred creation : 0.75 seconds (26% longer than current)ColorChooser
with deferred creation : 0.35 seconds (53% shorter than without deferred)Checklist