InspectorColumnUI #6019
Merged
InspectorColumnUI #6019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Thanks Murray! I've taken this for a quick spin and haven't spotted any issues. I've basically ignored the deleted code and just taken a quick pass through the new code. That might mean I'm making comments on things I missed in previous review, in which case I apologise...
johnhaddon
approved these changes
Sep 4, 2024
This migrates the column-specific editing functionality from the Light Editor and Render Pass Editor to a common set of interactions on InspectorColumn itself. This is mostly a direct migration of the existing functionality from the two editors, with adjustments made where necessary to combine overlapping functionality.
murraystevenson
force-pushed
the
inspectorColumnUI
branch
from
d22a2ec to
a61490d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the column-specific editing interactions from the Light Editor and Render Pass Editor to a common set of functionality on InspectorColumn. This consolidates duplicate code, makes the existing functionality available to any other editor with a PathListingWidget containing InspectorColumns and gives us a centralised place to begin extending and improving the editing experience.