Viewer config : Add diagnostic shading mode for usd:purpose #5983
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some open questions here :
Cs
primitive variables on an object. It feels like we should fix this, but I'm not sure where - the easiest would be to use a different shader thanConstant
. Should this be a new shader, in which case what should it be called or should it be private ? Or should we use the existingFacingRatio
?includedPurposes
on so you are visualising, or is that surprising or at the very least a performance hazard.