Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GafferTractorTest : Test using mock API if Tractor unavailable #5568

Merged
merged 1 commit into from
Nov 28, 2023
Merged

GafferTractorTest : Test using mock API if Tractor unavailable #5568

merged 1 commit into from
Nov 28, 2023

Conversation

johnhaddon
Copy link
Member

This allows us to run GafferTractorTest and GafferTractorUITest in CI even though we don't have Tractor installed.

@johnhaddon johnhaddon requested a review from ericmehl November 28, 2023 13:12
@johnhaddon johnhaddon self-assigned this Nov 28, 2023
@johnhaddon
GafferTractorTest : Test using mock API if Tractor unavailable
f7bf8f7 
This allows us to run GafferTractorTest and GafferTractorUITest in CI even though we don't have Tractor installed.
ericmehl
ericmehl approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@ericmehl ericmehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice to get some more test coverage running regularly on CI.

@johnhaddon johnhaddon merged commit d1d6014 into GafferHQ:main Nov 28, 2023
3 of 4 checks passed
@johnhaddon johnhaddon deleted the tractorTesting branch December 6, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmehl ericmehl ericmehl approved these changes

Assignees

@johnhaddon johnhaddon

Labels
None yet
Projects
Work in Progress
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnhaddon @ericmehl