GraphEditor : Create SceneReader, ImageReader or Reference nodes from file drag & drop #5564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't assume that if `dropSignal()` is emitted it was because _we_ accepted `dragEnterSignal()`. Another slot connected to `dragEnterSignal()` may have accepted it instead, in which case we don't want to do anything in our `GraphEditor.__drop`, on the assumption that another connection to `dropSignal()` will be dealing with it.
murraystevenson
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Thanks John! Confirmed working on Linux and Windows. One thought that passed my mind while reviewing was that it might be more descriptive/instructive to permit a drop in the Graph Editor if any of the dragged files are handled and then display an error for the unhandled files, rather than only permitting a drop if all dragged files are handled, but I'm happy to see this merged as is...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to drag and drop files from the OS file browser to the GraphEditor, automatically creating an appropriate node for reading each particular file. I've only tested it on Mac OS so far.