Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arnold : Fix UsdPreviewSurface translation bugs #5563

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Arnold : Fix UsdPreviewSurface translation bugs #5563

merged 2 commits into from
Nov 24, 2023

Conversation

johnhaddon
Copy link
Member

This fixes the translation of normal maps and specularColor fallback values. For testing, I found the following assets helpful :

@johnhaddon johnhaddon self-assigned this Nov 23, 2023
@johnhaddon johnhaddon changed the base branch from main to 1.3_maintenance November 23, 2023 18:23
murraystevenson
murraystevenson approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@murraystevenson murraystevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnhaddon johnhaddon merged commit 6b399a3 into GafferHQ:1.3_maintenance Nov 24, 2023
4 checks passed
@johnhaddon johnhaddon deleted the usdNormalMap branch December 6, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murraystevenson murraystevenson murraystevenson approved these changes

Assignees

@johnhaddon johnhaddon

Labels
None yet
Projects
Work in Progress
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnhaddon @murraystevenson