Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer contextlib.suppress() to IECore.IgnoredExceptions #5562

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Prefer contextlib.suppress() to IECore.IgnoredExceptions #5562

merged 1 commit into from
Nov 27, 2023

Conversation

johnhaddon
Copy link
Member

This is another thing we can ditch now we're exclusively on Python 3.

@johnhaddon
Prefer contextlib.suppress() to IECore.IgnoredExceptions
b1a04bd 
This is another thing we can ditch now we're exclusively on Python 3.
@johnhaddon johnhaddon requested a review from ericmehl November 23, 2023 13:49
@johnhaddon johnhaddon self-assigned this Nov 23, 2023
ericmehl
ericmehl approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@ericmehl ericmehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice to get a little more out of Python 3!

@ericmehl ericmehl merged commit 09c90de into GafferHQ:main Nov 27, 2023
4 checks passed
@johnhaddon johnhaddon deleted the suppressNotIgnore branch December 6, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmehl ericmehl ericmehl approved these changes

Assignees

@johnhaddon johnhaddon

Labels
None yet
Projects
Work in Progress
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnhaddon @ericmehl