Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScenePathPlugValueWidget : Use SceneAlgo.sourceScene() to find scene #5544

Conversation

johnhaddon
Copy link
Member

This allows us to find a scene when the focused node outputs a rendered image rather than a scene. This PR is a quick followup to #5540, implementing a suggestion @ericmehl had in the review there.

This allows us to find a scene when the focused node outputs a rendered image rather than a scene.
@johnhaddon johnhaddon requested a review from ericmehl November 15, 2023 10:13
@johnhaddon johnhaddon self-assigned this Nov 15, 2023
Copy link
Collaborator

@ericmehl ericmehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works nicely and hopefully will be useful in practice.

@johnhaddon johnhaddon merged commit 6553688 into GafferHQ:1.3_maintenance Nov 15, 2023
3 of 4 checks passed
@johnhaddon johnhaddon deleted the scenePathPlugValueWidgetSourceScene branch December 6, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants