OpenColorIOTransformBinding : Add missing ScopedGILRelease #5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing hangs when opening old Gaffer files in `1.3.x`, if the user's default layout was such that the Viewer would start a compute as soon as the file was opened. In this case, `acquireDefaultConfigPlug()` was still holding the GIL while creating the plug, and creating the plug would request cancellation of the compute, and the compute couldn't cancel if it was waiting for the GIL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing hangs when opening old Gaffer files in
1.3.x, if the user's default layout was such that the Viewer would start a compute as soon as the file was opened. In this case,acquireDefaultConfigPlug()was still holding the GIL while creating the plug, and creating the plug would request cancellation of the compute, and the compute couldn't cancel if it was waiting for the GIL.