CollectImages : Add addLayerPrefix plug
#5524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes quadratic performance in number of layer names, because we were calling `sourceLayerAndChannel()` once per output channel, and it was looping over all the input layers. This gives a modest 30% reduction in runtime for `testHighLayerCountPerformance`. That's not the main motivation for MappingData though - it provides the necessary foundations for the next commit.
This is motivated by the discussion at https://groups.google.com/u/1/g/gaffer-dev/c/kJQ5fuKIHP8, where folks are trying to collect light group outputs from Arnold, where they are inevitably already prefixed with the layer name in the EXR file.
|
Oh, I see Murray is assigned as reviewer on this - but I took a skim through it, and the only issue I see is that when |
Good point. I've pushed a fixup containing a fairly lame attempt at improving that. I tried to write something more helpful but couldn't find the good words - and decided that maybe the comment on |
|
Fixup seems reasonable. |
murraystevenson
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by the discussion at https://groups.google.com/u/1/g/gaffer-dev/c/kJQ5fuKIHP8, where folks are trying to collect light group outputs from Arnold, where they are inevitably already prefixed with the layer name in the EXR file.