ValuePlug : Remove deprecated getObjectValue() method
#5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
This was superceded by the overload with the `owner` argument in Gaffer 1.3, and was only kept for backwards compatibility. Likewise, remove the equivalent `getValueInternal()` method, which we needed to keep in 1.3 despite it being private, because it was called by inline public methods.
johnhaddon
force-pushed
the
removeValuePlugDeprecations
branch
from
8873b5f to
fc1207a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the methods deprecated in #5520. It also includes the fix from #5522 so that the CI can pass.