Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RendererAlgo : Default render:includedPurposes to default, render #5521

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

johnhaddon
Copy link
Member

This is the expected default that avoids doubling up proxy and render geometry in the same image. We couldn't use that for the default in 1.3.x as it would have been a breaking change that could affect existing renders, but we want to provide the best default behaviour in 1.4.

@johnhaddon johnhaddon self-assigned this Nov 1, 2023
Copy link
Contributor

@murraystevenson murraystevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is the expected default that avoids doubling up `proxy` and `render` geometry in the same image. We couldn't use that for the default in `1.3.x` as it would have been a breaking change that could affect existing renders, but we want to provide the best default behaviour in 1.4.
@johnhaddon johnhaddon force-pushed the includedPurposesDefault branch from 33d7bc7 to ab49809 Compare November 17, 2023 09:49
@johnhaddon johnhaddon merged commit c502d1e into GafferHQ:main Nov 17, 2023
3 checks passed
@johnhaddon johnhaddon deleted the includedPurposesDefault branch December 6, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants