Crop Window Toggle #5518
Merged
Crop Window Toggle #5518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
requested changes
Nov 3, 2023
ericmehl
force-pushed
the
cropWindowToggle
branch
from
f3b6342 to
34a7926
Compare
|
I addressed the comments above - despite it being a bit weird that two of the CI builds failed in tests, I think this is ready for another look. Those failures seem unrelated. |
johnhaddon
requested changes
Nov 9, 2023
Definitely. I've pushed bf248a4 to take care of one of them. The Windows one I've seen before too, but don't know the cause yet. |
ericmehl
force-pushed
the
cropWindowToggle
branch
from
34a7926 to
9272959
Compare
|
Squashed and ready for merging as long as my |
Previously we were only toggling non-exclusive tools off with keyboard shortcuts. This changes toggle behavior to activate the first tool in a toolbar when an exclusive tool is toggled off. This is initially motivated by the desire to be able to toggle off the CropWindowTool.
ericmehl
force-pushed
the
cropWindowToggle
branch
from
9272959 to
1e105c8
Compare
ericmehl
commented
Nov 15, 2023
| void toolsChildAdded( Gaffer::GraphComponent *child ); | ||
| void toolPlugSet( Gaffer::Plug *plug ); | ||
|
|
||
| using ToolPlugSetMap = std::unordered_map<Tool *, Gaffer::Signals::ScopedConnection>; |
There was a problem hiding this comment.
In the last push, I changed this to be keyed to Tool * instead of the name of the tool. Though we don't expect the tool name to change, it is possible. Keying on Tool * is more reliable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes two related behaviors :
Alt+Cshortcut to toggle off the crop window tool as well as the crop window itself, for the plug used for the crop window tool.Checklist