Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightTool : Remove unused variables #5517

Conversation

ericmehl
Copy link
Collaborator

I don't know why this was not caught during the builds for #5483, but @danieldresser found that offset is causing a warning about offset not being used in LengthHandle::setupDrag(). inspection in that same function is also not being used, so I removed it as well.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

@johnhaddon
Copy link
Member

I already removed that and some more in #5514 which I opened yesterday - you're down as the reviewer :)

@ericmehl
Copy link
Collaborator Author

Ahhhh, those were the Mac build fixes. Moving along then, nothing to see here...

@ericmehl ericmehl closed this Oct 27, 2023
@ericmehl ericmehl deleted the lightTool-remove-unused-variable branch October 27, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants