OSL indexed context queries #5515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ericmehl
force-pushed
the
oslScenePath
branch
3 times, most recently
from
2caea38 to
0187a57
Compare
johnhaddon
reviewed
Nov 1, 2023
ericmehl
force-pushed
the
oslScenePath
branch
from
0187a57 to
4a8e7b8
Compare
|
I addressed the comments and pushed a new branch this morning. Looks like the test failure is the expected one of handling |
johnhaddon
reviewed
Nov 3, 2023
johnhaddon
force-pushed
the
oslScenePath
branch
from
4a8e7b8 to
42b6192
Compare
|
Rebased to squash fixups and get this on top of #5525, whereafter CI should pass. |
ericmehl
force-pushed
the
oslScenePath
branch
from
42b6192 to
2a27109
Compare
|
And one last rebase to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to query specific indices of a vector-typed context variable in OSL. The original motivation was querying the
scene:pathcontext variable as described in #5292. The method was simple to generalize for all supported vector types, so those can be queried by index too.I'm opening this now as a work-in-progress so I can mention this PR in a related Cortex PR. There are still a couple things left to do before it's ready for review.
Related issues
Fixes #5292
Dependencies
ImageEngine/cortex#1391
Checklist