ImageView : Change default comparison mode to "replace" #5497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a render debugging session where I and some senior colleagues took an embarassingly amount of time to realise that two partially transparent alphas were actually identical, and one only looked brighter because it was being composited over the other. 😳 😳 😳
We had originally defaulted the comparison mode to "over" because we anticipated it being used most commonly to view an image over a plate, but a quick survey of users suggests that it is far more common to be just doing a straight up image comparison. And several users hadn't even realised that this wasn't actually what was happening by default...