Spreadsheet : Make string popups wider #5484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmehl
force-pushed
the
stringPopupWider
branch
from
e5a536a to
fc010b1
Compare
johnhaddon
requested changes
Oct 2, 2023
ericmehl
force-pushed
the
stringPopupWider
branch
from
fc010b1 to
c589054
Compare
johnhaddon
force-pushed
the
stringPopupWider
branch
from
fa15f79 to
4c6cf42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this accomplishes what we wanted to improve for the spreadsheet popup widgets. I'm setting the character width to 60 for the text widgets of both string cells and the row name.
What might be even better is to match the widget width to the column width, but as far as I can tell there's no current way to know what column the plug is being created on behalf of.
Checklist