-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add render:includedPurposes
option
#5470
Add render:includedPurposes
option
#5470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems to behave quite nicely. A couple of minor UI suggestions, but otherwise looks good.
I do wonder a bit at the practicality of being able to disable the "Default" purpose, seeing as that would typically remove all lights and cameras, but the option does seem worth including for completeness.
Thanks for the review and the UI suggestions - I've pushed a fixup to address them.
Yeah, I did wonder a bit about that - maybe one potential use is to turn it off so you can use the Viewer to find all your "Proxy" objects? I've added a comment to the tooltip mentioning that maybe you probably don't want to turn it off other than for debugging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for those updates!
This allows the visibility of each individual USD purpose (default, render, proxy, guide) in interactive and batch renders to be controlled by a StandardOptions node. Similarly, a new menu in the Viewer provides the equivalent viewer-specific overrides, plus the option of falling back and using the settings from the scene.
What's missing here is the application of this option to the contents of Capsules when they're rendered. This is proving to be a bit fiddly, so I'd like to get the basics reviewed and merged first so that we can focus on just the Capsule details in a followup PR.