PlugPopup : Fix error when popups have no PlugValueWidget

This could occur when a popup was created from multiple plugs of differing type, where we'd display a message rather than a PlugValueWidget.
GafferHQ · Oct 31, 2024 · d70acf7 · d70acf7
1 parent 67f9344
commit d70acf7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/Changes.md b/Changes.md
@@ -1,7 +1,10 @@
 1.4.x.x (relative to 1.4.15.0)
 =======
 
+Fixes
+-----
 
+- PlugPopup : Fixed error when displaying a popup with no PlugValueWidget.
 
 1.4.15.0 (relative to 1.4.14.0)
 ========

diff --git a/python/GafferUI/PlugPopup.py b/python/GafferUI/PlugPopup.py
@@ -157,7 +157,7 @@ def __visibilityChanged( self, unused ) :
 
 	def __focusChanged( self, oldWidget, newWidget ) :
 
-		if self.__plugValueWidget.isAncestorOf( newWidget ) and hasattr( newWidget, "activatedSignal" ) :
+		if self.__plugValueWidget and self.__plugValueWidget.isAncestorOf( newWidget ) and hasattr( newWidget, "activatedSignal" ) :
 			self.__widgetActivatedConnection = newWidget.activatedSignal().connect(
 				Gaffer.WeakMethod( self.__activated ), scoped = True
 			)