Merge pull request #6193 from johnhaddon/codeCompletionTweaks

PythonCompleter : Don't evaluate properties

Changes.md

@@ -14,6 +14,7 @@ Improvements
 - Viewer :
   - The shading mode menu icon now updates to indicate when a non-default shading mode is in use.
   - Added the ability to toggle between default shading and the last selected shading mode by <kbd>Ctrl</kbd> + clicking the shading mode menu button.
+- PythonEditor : Added workaround for slow code completion caused by poorly performing Python property getters.
 
 Fixes
 -----

python/GafferUI/CodeWidget.py

@@ -586,7 +586,19 @@ def __attrAndItemCompletions( self, text ) :
 			items = []
 			for n in dir( rootObject ) :
 				with IECore.IgnoredExceptions( AttributeError ) :
-					items.append( ( n, getattr( rootObject, n ) ) )
+					if not isinstance( getattr( type( rootObject ), n, None ), property ) :
+						# Get the value using `getattr()`, so that
+						# `__completions()` can distinguish between callable and
+						# non-callable values.
+						items.append( ( n, getattr( rootObject, n ) ) )
+					else :
+						# Avoid calling the property getter to get the attribute
+						# value, because one particular Gaffer pipeline has many
+						# slow-to-get properties. We assume that this is no
+						# great loss in other pipelines, because it is unlikely that
+						# a property returns a callable.
+						items.append( ( n, None ) )
+
 			return self.__completions(
 				items = items,
 				prefix = prefix, partialName = partial[1:],