Skip to content

Commit

Permalink
Merge pull request #6126 from ivanimanishi/RenderCompatibilityFix
Browse files Browse the repository at this point in the history
renderCompatibility : Add default node name
  • Loading branch information
johnhaddon authored Oct 31, 2024
2 parents 59206b6 + 5d53b2d commit 9f7f4f7
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 7 deletions.
5 changes: 5 additions & 0 deletions Changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ Improvements

- Instancer : Added support for 64 bit ints for ids ( matching what is loaded from USD ).

Fixes
-----

- Render, InteractiveRender : Added default node name arguments to the compatibility shims for removed subclasses such as ArnoldRender.

1.5.0.1 (relative to 1.5.0.0)
=======

Expand Down
4 changes: 2 additions & 2 deletions startup/GafferArnold/renderCompatibility.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@
import GafferScene
import GafferArnold

def __arnoldRender( name ) :
def __arnoldRender( name = "ArnoldRender" ) :

node = GafferScene.Render( name )
node["renderer"].setValue( "Arnold" )
return node

GafferArnold.ArnoldRender = __arnoldRender

def __interactiveArnoldRender( name ) :
def __interactiveArnoldRender( name = "InteractiveArnoldRender" ) :

node = GafferScene.InteractiveRender( name )
node["renderer"].setValue( "Arnold" )
Expand Down
4 changes: 2 additions & 2 deletions startup/GafferCycles/renderCompatibility.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@
import GafferScene
import GafferCycles

def __cyclesRender( name ) :
def __cyclesRender( name = "CyclesRender" ) :

node = GafferScene.Render( name )
node["renderer"].setValue( "Cycles" )
return node

GafferCycles.CyclesRender = __cyclesRender

def __interactiveCyclesRender( name ) :
def __interactiveCyclesRender( name = "InteractiveCyclesRender" ) :

node = GafferScene.InteractiveRender( name )
node["renderer"].setValue( "Cycles" )
Expand Down
4 changes: 2 additions & 2 deletions startup/GafferDelight/renderCompatibility.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@
import GafferScene
import GafferDelight

def __delightRender( name ) :
def __delightRender( name = "DelightRender" ) :

node = GafferScene.Render( name )
node["renderer"].setValue( "3Delight" )
return node

GafferDelight.DelightRender = __delightRender

def __interactiveDelightRender( name ) :
def __interactiveDelightRender( name = "InteractiveDelightRender" ) :

node = GafferScene.InteractiveRender( name )
node["renderer"].setValue( "3Delight" )
Expand Down
2 changes: 1 addition & 1 deletion startup/GafferScene/renderCompatibility.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

import GafferScene

def __openGLRender( name ) :
def __openGLRender( name = "OpenGLRender" ) :

node = GafferScene.Render( name )
node["renderer"].setValue( "OpenGL" )
Expand Down

0 comments on commit 9f7f4f7

Please sign in to comment.