Fix biome IDs over 255 not working for Magic Map and the Stream biome #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mitchej123
requested changes
Dec 21, 2024
| @@ -94,7 +94,7 @@ public void updateMapData(World world, Entity entity, TFMagicMapData mapData) { | |||
| boolean var20 = xOffset * xOffset + zOffset * zOffset > (drawSize - 2) * (drawSize - 2); | |||
| int xDraw2 = (xCenter / scaleFactor + xStep - xSize / 2) * scaleFactor; | |||
| int zDraw2 = (zCenter / scaleFactor + zStep - zSize / 2) * scaleFactor; | |||
| int[] biomeFrequencies = new int[256]; | |||
| int[] biomeFrequencies = new int[32768]; | |||
There was a problem hiding this comment.
This should not be hardcoded and instead should be based on the presence (or lack thereof) of ID extenders.
|
@48a3efa65c881ef567345b17f3910e06 any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that when auto generating biome ids it still uses the old range of 256 but this shouldn't be a problem because you would have changed all the biome configs anyawy