Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse modelview in firefly render #95

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

charagarlnad
Copy link

allocating a new FloatBuffer every frame is silly and generates significant garbage

@Glease
Copy link

Glease commented Dec 17, 2024

I don't understand what this is doing. It gets the modelview matrix into a buffer, then overwrite the buffer with identity matrix, then write it back to modelview matrix? what's the point of that? why not just use glLoadIdentity? nevermind. overlooked the loop code and it actually only overwrites the top-left 3x3

@mitchej123 mitchej123 merged commit 2a1e618 into GTNewHorizons:master Dec 17, 2024
1 check passed
Dream-Master pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants