-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Aluminum Gravel Ore with Zinc Gravel Ore, and deal with the consequences #1181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial brief review, I'll go through this in-depth when I have some more time this weekend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, I tested this and everything seems to work well. Nightly testing seems to have gone fine as well
Fulfills Area of Interest: Replace ALuminium gravel with another material to eliminate tier problems in GT. Read https://discord.com/channels/181078474394566657/1323615140880580608 for the full story.
Some of the changes shown here are implemented in the modpack PR and in the GT5 PR. They should be merged together.
Zinc Gravel Ore
Replaces Aluminum in XP bucket recipes.
Brass replaces Aluminum Brass almost everywhere
Except the Aluminum Brass Singularity, replaced by a Rose Gold Singularity
Postea converstion
Handles Aluminum Gravel Ore, solid Alumnium Brass items and blocks and Molten Aluminum Brass in smelteries, nothing else.
Before
After
Alumite is renamed to Obzinite and has it's recipe changed.
Zinc replaces Aluminium in equal quantities. TiCo parts with Alumite are unaffected and need no conversions.
Searching for Alumite still lets you find Obzinite for a seamless transition.
Tinker manuals are updated
Cobalt Brass uses Zinc instead of Aluminum
I used tin instead of Zinc because Zinc is already present in brass, and I've seen that Tin can be an IRL brass component.
Out of scope for this set of PRs.
Final word
I'll think twice before starting to work on such a "simple" change again.