Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Aluminum Gravel Ore with Zinc Gravel Ore, and deal with the consequences #1181

Merged
merged 18 commits into from
Jan 26, 2025

Conversation

YannickMG
Copy link
Contributor

@YannickMG YannickMG commented Jan 24, 2025

Fulfills Area of Interest: Replace ALuminium gravel with another material to eliminate tier problems in GT. Read https://discord.com/channels/181078474394566657/1323615140880580608 for the full story.

Some of the changes shown here are implemented in the modpack PR and in the GT5 PR. They should be merged together.

Zinc Gravel Ore

image
image
Replaces Aluminum in XP bucket recipes.
image

Brass replaces Aluminum Brass almost everywhere

image
image

Except the Aluminum Brass Singularity, replaced by a Rose Gold Singularity

rose-gold-recipe
meteoric-singularity-recipe

Postea converstion

Handles Aluminum Gravel Ore, solid Alumnium Brass items and blocks and Molten Aluminum Brass in smelteries, nothing else.

Before

before

After

after

Alumite is renamed to Obzinite and has it's recipe changed.

Zinc replaces Aluminium in equal quantities. TiCo parts with Alumite are unaffected and need no conversions.
image
image
image

Searching for Alumite still lets you find Obzinite for a seamless transition.
image

Tinker manuals are updated

image

Cobalt Brass uses Zinc instead of Aluminum

I used tin instead of Zinc because Zinc is already present in brass, and I've seen that Tin can be an IRL brass component.
image
image
image

Out of scope for this set of PRs.

  • Quests will be done after everything is merged. (and not by me)
  • Aluminium ore berries and raw alumimium are untouched, but will be made available later like in MV or at the earliest in the twilight forest through quest updates.
  • Magnalium can have it's quest moved to the Twilight Forest.

Final word

I'll think twice before starting to work on such a "simple" change again.

Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial brief review, I'll go through this in-depth when I have some more time this weekend

@YannickMG YannickMG changed the title Replace Aluminum Gravel Ore with Zing Gravel Ore, and deal with the consequences Replace Aluminum Gravel Ore with Zinc Gravel Ore, and deal with the consequences Jan 24, 2025
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 24, 2025
@Dream-Master Dream-Master requested a review from a team January 24, 2025 18:38
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I tested this and everything seems to work well. Nightly testing seems to have gone fine as well

@serenibyss serenibyss merged commit 84d8933 into master Jan 26, 2025
4 checks passed
@serenibyss serenibyss deleted the tico-zinc branch January 26, 2025 05:11
@serenibyss serenibyss removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects Balance Requires admin approval before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants