-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NC hatches for PCB Factory and QFT #3737
Open
GDCloudstrike
wants to merge
37
commits into
master
Choose a base branch
from
fix_stocking_dupes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,001
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDCloudstrike
added
enhancement
Improve an existing mechanic. Please explain the change with a before/after comparison.
new feature
Add something new. Please explain in detail how it works.
labels
Dec 30, 2024
Dream-Master
added
the
🚧 Testing on Zeta
Do not merge yet, testing this PR on Zeta
label
Jan 1, 2025
Should mention them in QFT's and PCB's tooltip |
# Conflicts: # src/main/java/gregtech/api/enums/ItemList.java
Warning: 2 uncommitted changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🚧 Testing on Zeta
Do not merge yet, testing this PR on Zeta
enhancement
Improve an existing mechanic. Please explain the change with a before/after comparison.
new feature
Add something new. Please explain in detail how it works.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds hatches that are designed to hold mass amounts of nonconsumable items for use in multiblocks. They act identically to super chests and have filtering for items they are allowed to use for their purpose (e.g. Nanite Bus only allows insertion of nanites). The UI also features a new button for locking the output slot, enabled by default (to not lose out on the first inserted stack).
The main reason for the addition of these hatches is to eliminate the stocking bus exploit that allowed an infinite amount of nonconsumables to be used in recipes even with only a single item (because of multiple storage buses reporting multiples of the real item).
This PR adds two of these hatches, the Nanite Containment Bus and the Bulk Catalyst Housing, for use in the PCB factory and QFT respectively. These can be reused in other multiblocks too if needed, and new ones can be added with relative ease.
The processing logic of the PCB factory and QFT has also been adjusted to check for the nonconsumables in the hatches directly, instead of searching in regular input buses (meaning cribs wont break).
Recipes will follow in a coremod PR.