Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NC hatches for PCB Factory and QFT #3737

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

GDCloudstrike
Copy link
Member

This PR adds hatches that are designed to hold mass amounts of nonconsumable items for use in multiblocks. They act identically to super chests and have filtering for items they are allowed to use for their purpose (e.g. Nanite Bus only allows insertion of nanites). The UI also features a new button for locking the output slot, enabled by default (to not lose out on the first inserted stack).

The main reason for the addition of these hatches is to eliminate the stocking bus exploit that allowed an infinite amount of nonconsumables to be used in recipes even with only a single item (because of multiple storage buses reporting multiples of the real item).

This PR adds two of these hatches, the Nanite Containment Bus and the Bulk Catalyst Housing, for use in the PCB factory and QFT respectively. These can be reused in other multiblocks too if needed, and new ones can be added with relative ease.

The processing logic of the PCB factory and QFT has also been adjusted to check for the nonconsumables in the hatches directly, instead of searching in regular input buses (meaning cribs wont break).

Recipes will follow in a coremod PR.

image
image

@GDCloudstrike GDCloudstrike added enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. new feature Add something new. Please explain in detail how it works. labels Dec 30, 2024
@Dream-Master Dream-Master requested a review from a team December 31, 2024 12:00
@HoleFish
Copy link
Contributor

HoleFish commented Jan 5, 2025

Should mention them in QFT's and PCB's tooltip

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Warning: 2 uncommitted changes
#3769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. new feature Add something new. Please explain in detail how it works.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants