Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor iconsets folder #3381

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Refactor iconsets folder #3381

wants to merge 29 commits into from

Conversation

BlueHero233
Copy link
Member

Picked up on a old pr ive tried to organize the iconsets folder
Brother PR GTNewHorizons/Crops-plus-plus#80

@BlueHero233 BlueHero233 added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Oct 16, 2024
@BlueHero233 BlueHero233 requested a review from a team October 16, 2024 16:16
@NotAPenguin0 NotAPenguin0 added the refactor For PRs rewritting a part of the code to have a nicer code overall. label Oct 17, 2024
@NotAPenguin0 NotAPenguin0 changed the title Small fixes Refactor iconsets folder Oct 17, 2024
@boubou19 boubou19 added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Oct 17, 2024
@BlueHero233
Copy link
Member Author

Charcoal Pit and Advanced Seismic Prospector
2024-11-01_10 01 50
2024-11-01_10 01 59
2024-11-01_10 02 07

@BlueHero233
Copy link
Member Author

Radioisotope Thermoelectric Generator
2024-11-01_10 03 34
2024-11-01_10 03 37

@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Nov 16, 2024
@BlueHero233
Copy link
Member Author

BlueHero233 commented Nov 17, 2024

Needs to merge this PR first and create a new gt tag on Cpp repo for it to build properly (and not throw a npe down on RC1)

@serenibyss serenibyss added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Nov 23, 2024
@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Dec 8, 2024
Comment on lines -70 to +55
TextureFactory.of(OVERLAY_SIDE_ROCK_BREAKER_ACTIVE),
TextureFactory.of(new Textures.BlockIcons.CustomIcon("basicmachines/seismic/OVERLAY_SIDE_ACTIVE")),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change these all to no longer use the fields in Textures?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When making my resource pack, it was bothering me that the rock breaker texture was being reused on other machines that definetely didnt look or work like a rock breaker, so along with creating a different texture for such machines, i also moved them to basicmachines, as a way to keep single block machine textures consistent instead of adding more fields to the textures enum and making the iconsets folder even bigger

@Dream-Master Dream-Master requested a review from a team December 18, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. refactor For PRs rewritting a part of the code to have a nicer code overall.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants