-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor iconsets folder #3381
base: master
Are you sure you want to change the base?
Refactor iconsets folder #3381
Conversation
…sicmachines instead of bloating iconsets
…tor and Synthesiser textures to basicmachines See brother PR
…ockbreaker and Moved it to basicmachines
Needs to merge this PR first and create a new gt tag on Cpp repo for it to build properly (and not throw a npe down on RC1) |
TextureFactory.of(OVERLAY_SIDE_ROCK_BREAKER_ACTIVE), | ||
TextureFactory.of(new Textures.BlockIcons.CustomIcon("basicmachines/seismic/OVERLAY_SIDE_ACTIVE")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change these all to no longer use the fields in Textures
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When making my resource pack, it was bothering me that the rock breaker texture was being reused on other machines that definetely didnt look or work like a rock breaker, so along with creating a different texture for such machines, i also moved them to basicmachines, as a way to keep single block machine textures consistent instead of adding more fields to the textures enum and making the iconsets folder even bigger
Picked up on a old pr ive tried to organize the iconsets folder
Brother PR GTNewHorizons/Crops-plus-plus#80