Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thousandth mark for cell tooltips. #174

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

MCTBL
Copy link
Member

@MCTBL MCTBL commented Nov 25, 2023

No description provided.

@MCTBL
Copy link
Member Author

MCTBL commented Nov 25, 2023

image
Make the large number more readable.

@Dream-Master Dream-Master requested a review from a team November 25, 2023 16:10
@bombcar
Copy link
Member

bombcar commented Nov 25, 2023

I understand what it’s doing but giga milibuckets feels weird. I know the vote went against liters ….

@MCTBL
Copy link
Member Author

MCTBL commented Nov 26, 2023

I understand what it’s doing but giga milibuckets feels weird. I know the vote went against liters ….

I still haven't noticed that before u mention me.

@MCTBL
Copy link
Member Author

MCTBL commented Dec 1, 2023

Should I add a condition can let it show the unit l when it identifies the GregTech, and show up the mB when without Greg?

@Hikari1nVoid
Copy link

I understand what it’s doing but giga milibuckets feels weird. I know the vote went against liters ….

Hey just treat them as items.That's why AE2FC turns every fluid into fluid drops,isn't it?

@MCTBL
Copy link
Member Author

MCTBL commented Dec 1, 2023

I understand what it’s doing but giga milibuckets feels weird. I know the vote went against liters ….

Wait, I may misunderstand what you were saying at first... That may be easy to fix, but I'm not sure is it necessary?

@bombcar
Copy link
Member

bombcar commented Dec 1, 2023

It's fine leave it as is.

1 Giga L makes sense (giga liters) but 1 Giga milliBucket is a bit weird, it'd be like kilo centimeters.

@MCTBL
Copy link
Member Author

MCTBL commented Dec 1, 2023

It's fine leave it as is.

1 Giga L makes sense (giga liters) but 1 Giga milliBucket is a bit weird, it'd be like kilo centimeters.

got you now.

@chochem
Copy link
Member

chochem commented Dec 1, 2023

I understand what it’s doing but giga milibuckets feels weird. I know the vote went against liters ….

we had one vote in either direction iirc. Anyway, I think its fair to assume that nobody wants Gigamilli for anything. thats just terrible. Guess its not touched here though, just in the pic.

@bombcar
Copy link
Member

bombcar commented Dec 1, 2023

I understand what it’s doing but giga milibuckets feels weird. I know the vote went against liters ….

we had one vote in either direction iirc. Anyway, I think its fair to assume that nobody wants Gigamilli for anything. thats just terrible. Guess its not touched here though, just in the pic.

Yeah, as far as this goes, the PR is correct unless anyone sees any other issues. To fix gigamili would require a GTNH-wide formatting tool that can fix it

Only downside to this is you may not be able to see if it is increasing/decreasing because the number won't change much.

@Connor-Colenso Connor-Colenso merged commit 3b1b1af into GTNewHorizons:master Dec 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants