Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolved bugs to start multiple simulations and services within multi… #1757

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

resolved bugs to start multiple simulations and services within multi… #1757

wants to merge 1 commit into from

Conversation

poorva1209
Copy link
Contributor

Resolved following :

  • Multiple simulations were not running properly.
  • SimulationManager and helics_goss_bridge were using the same topic for multiple simulations, hence simulation instances were interfering with each other statuses.

To test:

  • Start 2 simulation in parallel (Same or different models)
  • Both should start and complete successfully

@poorva1209 poorva1209 requested review from craig8 and afisher1 January 5, 2024 21:50
@poorva1209 poorva1209 changed the base branch from develop to cimext_master_merge November 25, 2024 19:52
@poorva1209 poorva1209 changed the base branch from cimext_master_merge to develop November 25, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig8 craig8 Awaiting requested review from craig8

@afisher1 afisher1 Awaiting requested review from afisher1

Assignees

@craig8 craig8

@afisher1 afisher1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poorva1209 @craig8 @afisher1