GPII-4171: Initial implementation of gpii-windows-installer #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added windowsService component that deals with the service build and copying the files to the target folders - Reworked the way the main component works - Reduced the size on disk of the final installer - Added dedupe-infusion and making use it - Updated adm-zip dependency - Some more minor updates
This is needed for the windows service to be created
Also, added the outputPath in data/artifacts.json5 for this new mechanism to copy the files to the right place.
Also, added some comments to the shrinkSize function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sketch implementation of the code that will help us to automate the creation of GPII installers.
The code is functional in a way that it is able to produce msi installers from the current master branch of gpii-app, but it's still in progress.