GPII-4253: Created initial gpii stubs for non-supported OSs #1
Conversation
package.json
Outdated
| }, | ||
| "homepage": "http://gpii.net/", | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1" |
There was a problem hiding this comment.
Please make this a no-op which returns true so that we stand a chance of enlisting this in CI : P
There was a problem hiding this comment.
Sorry, obviously I mean "0" rather than true : P
There was a problem hiding this comment.
Understood. npm test will now execute "exit 0" for the stubs.
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "dependencies": { | ||
| "gpii-universal": "JavierJF/universal#GPII-3810" |
There was a problem hiding this comment.
Why this branch rather than master or, even better, an npm artefact?
There was a problem hiding this comment.
For consistency, this is the same branch used by the Windows repository.
https://github.com/GPII/windows/blob/master/package.json
I can change it to any other repo/package/branch, as desired. To date, I have been testing specifically with the branch used by GPII/windows.
|
Please add standard linting tasks to package.json and a suitable Gruntfile - you can find a suitable minimal template at https://github.com/GPII/gpii-express/blob/master/Gruntfile.js and https://github.com/GPII/gpii-express/blob/master/package.json#L22-L26 |
|
Please also follow @the-t-in-rtf 's instructions in http://irc-logs.fluidproject.org/%23fluid-work/%23fluid-work.2019-12-13.log in order to set up vagrant definitions to be able to enlist this repo into CI |
No description provided.