Added dihedral fits tests and updated/fixed build errors in the docs #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bc118
commented
Aug 18, 2024
bc118
commented
- Added the rest of the newly created examples tests and additional tests to catch errors.
- Updated the docs text and removed errors and warnings when building the docs.
…ors. Updated the docs text and removed errors and warnings when building the docs.
daico007
approved these changes
Aug 18, 2024
| @@ -21,7 +44,7 @@ Import the required packages. | |||
| .. code:: ipython3 | |||
|
|
|||
| import unyt as u | |||
| from mosdef_dihedral_fit.dihedral_fit.fit_dihedral_with_gomc import fit_dihedral_with_gomc | |||
| #from mosdef_dihedral_fit.dihedral_fit.fit_dihedral_with_gomc import fit_dihedral_with_gomc | |||
There was a problem hiding this comment.
should we just remove this line?
There was a problem hiding this comment.
I actually left it this way (used 2x), thinking people will only copy each example.
There was a problem hiding this comment.
why are we removing it, do we not need it? I just test it and it is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.