-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angle construction error after upgrading to most recent version #335
Comments
Micah, thank you for your bug report. Can you please answer a few questions? First, I assume from your report that this was working correctly on an earlier version of the code. If so, for which version of GOMC was this working? Also, have you tried using the latest development branch? It has many bug fixes and, to the best of my knowledge, does not introduce any new bugs. I don't know that any of the changes will address your problem. |
Hi! I believe I was on version 2.4. I haven't tried the latest development branch. I can give it a shot. |
Update, the dev branch still yields the same error. From what I understand from previous commits, it could be related to the CBMC trial moves or a limitation with how GOMC handles the angles of planar molecules (i.e. the angles I have set in my forcefield file)? Could either of those be potential causes for the problem? |
Thanks for the update. That's very helpful. It could be that the problem is caused by something you mentioned. We will look into it asap and let you know. |
@GregorySchwing @LSchwiebert I suggest we take a look at the PSF parser, since we were recently doing a lot of work on how we were identifying rings in the system to address performance issues. |
I've gone ahead and tried building another polymer I'm interested in as a test and I'm not sure if it helps but it seems as if the issue is specifically being caused by angles in a ring involving an oxygen in that ring. For example this dimer of PDD is getting a "Cannot construct angle" error for the O-C-O and C-C-O angles in the rings. |
@micahwelsch I looked at your system and it seems that you angles are very flexible (angle force constants are very small). This would cause some issue with GOMC CD-CBMC algorithm. For any move that uses CD-CBMC, such as swap, intra-swap, regrowth, etc, when we sample angles in branching point, we fix the angle that belongs to ring (e.g. in the above picture O3-C6-O4) and we let crancshaft move samples this angle. This would cause issue for very flexible angle, because we cannot enforce the angle in the ring, due to geometrical constrain.
If we sample If you modify the equilibrium angles that involves an atom in the ring (X-FC2-X in your system), so that the sum of them is close to 360, you should be fine.
|
Interesting. I will give this a shot. To double check probably a silly question, the Ktheta that I provide should be in kcal/mol correct? Or do I provide it in kelvin and the software converts that automatically? What I've been using and what is in the example above is in kcal/mol. |
I believe you are using Mie parameter file, which force units are in kelvin. That's why angels are very flexible. |
I fixed the energy units and still found it necessary to adjust the angles as you suggested @msoroush to get the sum closer to 360. For a polymer system with a single unit long chain (monomer) I'm getting expected results. But with the 5 unit long chain (5 monomers) that I used as my initial example in this thread I'm still getting the angle construction error. The system can't seem to compress below a particular density and gives the angle construction error when it does manage to. I'm not entirely sure why that might be. Here's the inputs that are giving this result. |
Please let me know if #339 patch fixes your issue. |
Hello,
I have a polymer system that I constructed by
After upgrading to the most recent version of GOMC, I'm running into an issue where an angle in the furan ring of my polymer molecule that was previously okay is sending the "Cannot construct angle FC3 FC2 FO !" error at the start of a simulation.
To reproduce this error I have been using the GPU executable to run in the NPT ensemble
./GOMC_GPU_NPT in-eq.conf
I expected this NPT system to condense down to a bulk density and fluctuate at the temperature and pressure set as an amorphous polymer.
Image of angle in question, provided by Gregory Schwing on Gitter page
I'm attaching a zip file with all relevant files.
Software and System Details
ptf-angle-issue.zip
Additional info/context
The SMILE code for this pentamer of PTF I'm providing as an example is as follows (I believe):
O=C(O)c5ccc(C(=O)OCCCOC(=O)c4ccc(C(=O)OCCCCOC(=O)c3ccc(C(=O)OCCCC(=O)OCc2ccc(C(=O)OCCCOC(=O)c1ccc(C(=O)OCCCO)o1)o2)o3)o4)o5
The text was updated successfully, but these errors were encountered: