issue 306 - If no other user can approve a role request, email the GOCDB admins #331
Conversation
add method sendGocdbAdminsEmail to NotificationService.php to send a gocdb admin specific role approval email, and also call function in main roleRequest method if there are no approving users.
Cleanup for PR and change email to GOCDB admin list
|
Example test email: |
Did you post the comment before the upload had finished? |
Ahh I didn't realise it didn't upload, ill try again, thanks! |
| @@ -70,6 +70,8 @@ public function roleRequest ($roleRequested, $requestingUser, $entity) { | |||
| } | |||
| $projectIds = array_unique ( $projectIds ); | |||
| } | |||
| // Also send email to GOCDB Admins | |||
| $this->sendGocdbAdminsEmail($roleRequested, $requestingUser, $entity->getName()); | |||
There was a problem hiding this comment.
By putting this here, does that mean if an NGI role is requested and no one at the NGI level can approve, do the GOCDB admins get an email regardless of whether there is someone at the project level who can approve the request?
This probably needs a test suite/case, similar to #282 - but automated. |
resolves #306 merge after (#282 or a similar test case)