Code

Fix email issues#171

Code

Merged

gregcorbett merged 28 commits intoGOCDB:devGOCDB/gocdb:devfrom jrha:emailsjrha/gocdb:emailsCopy head branch name to clipboardOct 5, 2021

+133-81

Commits

Commits on Sep 30, 2021

• Enrich and personalise the role request emails.

  Show description for a8b6022
  

  2 peopleauthored and

  gregcorbett

  committed
  a8b6022

• Factor out preparation and sending of email to a seperate function

  Show description for e1ef4cd
  

  jrha

  authored and

  gregcorbett

  committed
  e1ef4cd

• Remove commented out code cruft

  

  jrha

  authored and

  gregcorbett

  committed
  08b7a7a

Commits on Oct 1, 2021

• Remove if statement from NotificationService call

  Show description for 3ee8160
  gregcorbett

  committed
  3ee8160

• Pass newRole and user to initial call to roleRequest

  

  jrha

  authored and

  gregcorbett

  committed
  a262b85

• Actually pass approving user to send_email

  

  jrha

  authored and

  gregcorbett

  committed
  e69c8bb

• Factor out getting of web PortalURL to a private function

  

  jrha

  authored and

  gregcorbett

  committed
  6db804d

• Add private mock mail function for debugging

  

  jrha

  authored and

  gregcorbett

  committed
  3382f89

• Read send_email from config file and act appropriately

  Show description for 4462025
  

  jrha

  authored and

  gregcorbett

  committed
  4462025

• Move headers next to where it is used

  

  jrha

  authored and

  gregcorbett

  committed
  f2f02ac

• Remove redundant code paths

  Show description for 3c9bbd9
  

  jrha

  authored and

  gregcorbett

  committed
  3c9bbd9

• Don't create single-use local variable for entity name

  

  jrha

  authored and

  gregcorbett

  committed
  d755b31

• Fix from header and set email address to admin list

  Show description for 7df9d51
  

  jrha

  authored and

  gregcorbett

  committed
  7df9d51

• Handle case where no user has a role over entity

  Show description for b156c28
  

  gregcorbett

  and

  ineilson

  committed
  b156c28

• Use the role requested object to populate email

  Show description for 9b8b9f2
  gregcorbett

  committed
  9b8b9f2

• Always recurse roleRequest when project role needed

  Show description for 443211e
  gregcorbett

  committed
  443211e

• Move enablingRoles initialisation closer to use

  gregcorbett

  committed
  845a027

• Use the Factory to access local config

  Show description for 0deddb5
  

  gregcorbett

  and

  ineilson

  committed
  0deddb5

• Remove un-needed code.

  Show description for eb54ec4
  gregcorbett

  committed
  eb54ec4

• Check array is empty rather than null

  Show description for c49b00c
  gregcorbett

  committed
  c49b00c

Commits on Oct 4, 2021

• Simplify determination of users with GRANT_ROLE

  Show description for 6efb29b
  

  gregcorbett

  and

  ineilson

  committed
  6efb29b

• Improve comments around recursion

  gregcorbett

  committed
  eac6b74

• Use camelCase throughout

  gregcorbett

  committed
  34bf0a8

• Factor out email sending into its own service

  Show description for 569fcde
  gregcorbett

  committed
  569fcde

• Update documentation of NotificationService class

  Show description for 1e0ad98
  

  gregcorbett

  and

  ineilson

  committed
  1e0ad98

• Capitalise "GocDB" in lib/Gocdb_Services/NotificationService.php

  Show description for 82abbed
  

  gregcorbett

  and

  ineilson

  committed
  82abbed

• Add requesting User's surname to emails

  Show description for 6f6d342
  gregcorbett

  committed
  6f6d342

• Remove unneeded check for emptiness

  Show description for 1dce398
  

  gregcorbett

  and

  ineilson

  authored
  1dce398